ChangeLog-1.4.42-2011-05-20 16:38 +0000 [r320055] David VosselChangeLog-1.4.42- ChangeLog-1.4.42- * channels/chan_sip.c: chan_sip: Destroy variables on a sip_pvt ChangeLog-1.4.42- before copying vars from the sip_peer. (closes issue #19202) ChangeLog-1.4.42: Reported by: wdoekes Patches: ChangeLog-1.4.42- issue19202_destroy_challenged_invite_chanvars.patch uploaded by ChangeLog-1.4.42: wdoekes (license 717) ChangeLog-1.4.42- ChangeLog-1.4.42-2011-05-05 14:54 +0000 [r317102] Leif Madsen ChangeLog-1.4.42- ChangeLog-1.4.42- * contrib/scripts/safe_asterisk: Disable console colourization ChangeLog-1.4.42- inside safe_asterisk checks. (closes issue #19213) Reported by: ChangeLog-1.4.42- lefoyer Patches: ChangeLog-1.4.42- issue19213_strip_color_in_safe_asterisk-svn.patch uploaded by ChangeLog-1.4.42: wdoekes (license 717) Tested by: wdoekes, lefoyer ChangeLog-1.4.42- ChangeLog-1.4.42-2011-04-27 18:57 +0000 [r315891] Matthew Nicholson ChangeLog-1.4.42- ChangeLog-1.4.42- * channels/chan_sip.c: Fix our compliance with RFC 3261 section ChangeLog-1.4.42- 18.2.2. This change optimizes the free_via() function and removes ChangeLog-1.4.42- some redundant null checking. It also fixes compliance with RFC ChangeLog-1.4.42- 3261 section 18.2.2 by always using the port specified in the Via ChangeLog-1.4.42- header for routing responses (even when maddr is not set). Also ChangeLog-1.4.42- the htons() function is now used when setting the port. ChangeLog-1.4.42- Additional documentation comments have been added in various ChangeLog-1.4.42- places to make the logic in the code clearer. (closes issue ChangeLog-1.4.42- #18951) Reported by: jmls Patches: ChangeLog-1.4.42: issue18951_set_proper_port_from_via.patch uploaded by wdoekes ChangeLog-1.4.42- (license 717) (modified) ChangeLog-1.4.42- ChangeLog-1.4.42-2010-10-01 16:20 +0000 [r289699] Jeff Peeler ChangeLog-1.4.42- ChangeLog-1.4.42- * channels/chan_sip.c: Ensure user portion of SIP URI matches ChangeLog-1.4.42- dialplan when using encoded characters. This commit takes a ChangeLog-1.4.42- simliar approach to 288112 and checks the dialplan to determine ChangeLog-1.4.42- the proper action for an incoming contact header as to whether or ChangeLog-1.4.42- not it should be decoded or not. sip_new was blindly always ChangeLog-1.4.42- decoding the extension, which also caused the outgoing contact ChangeLog-1.4.42- header to be incorrect as well as failing to match the encoded ChangeLog-1.4.42- extension in the dialplan. (closes issue #17892) Reported by: ChangeLog-1.4.42: wdoekes Patches: bug17892-1.patch uploaded by jpeeler (license ChangeLog-1.4.42: 325) Tested by: wdoekes ChangeLog-1.4.42- ChangeLog-1.4.42-2010-01-06 21:41 +0000 [r238230] Tilghman Lesher ChangeLog-1.4.42- ChangeLog-1.4.42- * funcs/func_cdr.c: Revise documentation on disposition values to ChangeLog-1.4.42- the actual values used. (closes issue #16289) Reported by: ChangeLog-1.4.42: wdoekes ChangeLog-1.4.42- ChangeLog-1.4.42-2010-01-04 21:45 +0000 [r237318-237573] Tilghman Lesher ChangeLog-1.4.42- ChangeLog-1.4.42- * main/pbx.c: Regression in issue #15421 - Pattern matching (closes ChangeLog-1.4.42: issue #16482) Reported by: wdoekes Patches: ChangeLog-1.4.42: astsvn-16482-betterfix.diff uploaded by wdoekes (license 717) ChangeLog-1.4.42- 20091223__issue16482.diff.txt uploaded by tilghman (license 14) ChangeLog-1.4.42: Tested by: wdoekes, tilghman ChangeLog-1.4.42- ChangeLog-1.4.42-2009-12-04 21:54 +0000 [r233116-233279] David Vossel ChangeLog-1.4.42- ChangeLog-1.4.42- * apps/app_voicemail.c: document and rename strip_control() in ChangeLog-1.4.42: app_voicemail (closes issue #16291) Reported by: wdoekes ChangeLog-1.4.42- ChangeLog-1.4.42-2009-12-02 16:59 +0000 [r232268-232350] David Vossel ChangeLog-1.4.42- ChangeLog-1.4.42- * main/acl.c: ast_outaddrfor doesn't do htons() on port, looks odd ChangeLog-1.4.42: in strace. (closes issue #16290) Reported by: wdoekes ChangeLog-1.4.42- ChangeLog-1.4.42-2009-04-20 22:02 +0000 [r189537] Tilghman Lesher ChangeLog-1.4.42- ChangeLog-1.4.42- * funcs/func_odbc.c, funcs/func_strings.c: Add a workaround for ChangeLog-1.4.42- func_odbc/ARRAY() for problems that occur with certain special ChangeLog-1.4.42- characters. In certain cases, due to the way Set() works in 1.4, ChangeLog-1.4.42- values may not get set properly. This is a workaround for 1.4 ChangeLog-1.4.42- only that corrects for these issues, without making func_odbc ChangeLog-1.4.42- more difficult to use properly. (closes issue #14614) Reported ChangeLog-1.4.42: by: wdoekes Patches: 20090309__bug14614__2.diff.txt uploaded by ChangeLog-1.4.42- tilghman (license 14) ChangeLog-1.4.42- double_set_unescape_workaround_for_func_odbc.osso-and-tilghman-1.diff ChangeLog-1.4.42: uploaded by wdoekes (license 717) Tested by: wdoekes, tilghman ChangeLog-1.4.42- ChangeLog-1.6.2.19-2011-05-23 16:15 +0000 [r320506-320562] David Vossel ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * main/tcptls.c: Adds missing part to the ast_tcptls_server_start ChangeLog-1.6.2.19- fails second attempt to bind patch. (closes issue #19289) ChangeLog-1.6.2.19: Reported by: wdoekes Patches: ChangeLog-1.6.2.19- issue19289_delay_old_address_setting_tcptls_2.patch uploaded by ChangeLog-1.6.2.19: wdoekes (license 717) ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * apps/app_chanspy.c: Fixes chanspy enforced mode lacking a ChangeLog-1.6.2.19: channel_unlock. (closes issue #19348) Reported by: wdoekes ChangeLog-1.6.2.19- Patches: issue19348_chanspy_missing_channel_unlock.patch uploaded ChangeLog-1.6.2.19: by wdoekes (license 717) ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2011-05-20 21:24 +0000 [r320271] David Vossel ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * main/tcptls.c: Fixes issue with ast_tcptls_server_start failing ChangeLog-1.6.2.19- on second attempt to bind. (closes issue #19289) Reported by: ChangeLog-1.6.2.19: wdoekes Patches: ChangeLog-1.6.2.19- issue19289_delay_old_address_setting_tcptls.patch uploaded by ChangeLog-1.6.2.19: wdoekes (license 717) ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2011-05-11 17:15 +0000 [r318548] Terry Wilson ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * channels/chan_sip.c: Clean up several chan_sip reference leaks ChangeLog-1.6.2.19- Several situations in the code could lead to peers or sip_pvt ChangeLog-1.6.2.19- references being leaked. This would cause RTP ports to never be ChangeLog-1.6.2.19- destroyed (leading to exhaustion of all available RTP ports) and ChangeLog-1.6.2.19- memory leaks. The original patch for this issue from rgagnon was ChangeLog-1.6.2.19- the result of an obscene amount of testing and hard work, for ChangeLog-1.6.2.19- which I am very grateful. I did some cleanup and added a few ChangeLog-1.6.2.19- additional refcount fixes that I found. (closes issue #17255) ChangeLog-1.6.2.19- Reported by: kvveltho Patches: ChangeLog-1.6.2.19- tag-1.6.2.17-r309252-sip-dos-mem-leak-fix.diff uploaded by ChangeLog-1.6.2.19: rgagnon (license 1202) Tested by: rgagnon, twilson, wdoekes, ChangeLog-1.6.2.19- loloski Review: https://reviewboard.asterisk.org/r/1101/ Review: ChangeLog-1.6.2.19- https://reviewboard.asterisk.org/r/1207/ ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2011-05-04 14:23 +0000 [r316616-316644] David Vossel ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * apps/app_chanspy.c: Fixes one-way-audio when chanspy activated ChangeLog-1.6.2.19- with the 'o' option (closes issue #18382) Reported by: jkister ChangeLog-1.6.2.19- Patches: ChangeLog-1.6.2.19- 0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch.txt ChangeLog-1.6.2.19- uploaded by malin (license ) Tested by: firstsip, Greenlightcrm, ChangeLog-1.6.2.19: malin, wdoekes, boroda, dvossel ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * channels/chan_sip.c: Fixes session-timers=refuse not being ChangeLog-1.6.2.19- enforced for *caller* During handle_request_invite, the session ChangeLog-1.6.2.19- timer mode was retrieved from a cached variable. This patch ChangeLog-1.6.2.19- forces a peer lookup of the session timer mode in the case of an ChangeLog-1.6.2.19: incoming invite. (closes issue #18804) Reported by: wdoekes ChangeLog-1.6.2.19- Patches: issue18804_session_timer_refuse_caller.patch uploaded by ChangeLog-1.6.2.19: wdoekes (license 717) issue_18804_v2.diff uploaded by dvossel ChangeLog-1.6.2.19- (license 671) ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2011-05-02 19:04 +0000 [r316093] Tilghman Lesher ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * funcs/func_curl.c: More possible crashes based upon invalid ChangeLog-1.6.2.19: inputs. (closes issue #18161) Reported by: wdoekes Patches: ChangeLog-1.6.2.19- 20110301__issue18161.diff.txt uploaded by tilghman (license 14) ChangeLog-1.6.2.19: Tested by: wdoekes ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2011-04-25 19:31 +0000 [r315212-315258] Russell Bryant ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * channels/chan_sip.c: Don't link non-cached realtime peers into ChangeLog-1.6.2.19- the peers_by_ip container. (closes issue #18924) Reported by: ChangeLog-1.6.2.19: wdoekes Patches: ChangeLog-1.6.2.19- issue18924_uncached_realtime_peers_leak-1.6.2.17.patch uploaded ChangeLog-1.6.2.19: by wdoekes (license 717) ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2011-01-19 19:02 +0000 [r302504-302554] Sean Bright ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * main/utils.c: Don't call strlen() when we only need to look at ChangeLog-1.6.2.19- the next character or two. (closes issue #18042) Reported by: ChangeLog-1.6.2.19: wdoekes Patches: astsvn-inefficient-ast-uri-decode.patch uploaded ChangeLog-1.6.2.19: by wdoekes (license 717) ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2010-11-15 18:24 +0000 [r294988-295062] Tilghman Lesher ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * funcs/func_curl.c: It is possible to crash Asterisk by feeding ChangeLog-1.6.2.19- the curl engine invalid data. (closes issue #18161) Reported by: ChangeLog-1.6.2.19: wdoekes Patches: 20101029__issue18161.diff.txt uploaded by ChangeLog-1.6.2.19- tilghman (license 14) Tested by: tilghman ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2010-10-28 16:09 +0000 [r293158] Jeff Peeler ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * funcs/func_strings.c: Fix infinite loop in FILTER(). Specifically ChangeLog-1.6.2.19- when you're using characters above \x7f or invalid character ChangeLog-1.6.2.19: escapes (e.g. \xgg). (closes issue #18060) Reported by: wdoekes ChangeLog-1.6.2.19- Patches: issue18060_func_strings_filter_infinite_loop.patch ChangeLog-1.6.2.19: uploaded by wdoekes (license 717) Tested by: wdoekes ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2010-05-17 19:37 +0000 [r263587-263590] Tilghman Lesher ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * main/app.c: Don't close 'n', just close 'above_n'. (closes issue ChangeLog-1.6.2.19: #17345) Reported by: wdoekes ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2010-02-18 23:15 +0000 [r247792-247845] Tilghman Lesher ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * /, channels/chan_sip.c: Merged revisions 247787 via svnmerge from ChangeLog-1.6.2.19- https://origsvn.digium.com/svn/asterisk/trunk ........ r247787 | ChangeLog-1.6.2.19- tilghman | 2010-02-18 15:42:53 -0600 (Thu, 18 Feb 2010) | 17 ChangeLog-1.6.2.19- lines If the peer record is from realtime, it could be set to 0, ChangeLog-1.6.2.19- due to MySQL not representing NULL well in integer columns. NULL ChangeLog-1.6.2.19- means the value is not specified for the column, which normally ChangeLog-1.6.2.19- means the driver uses whatever is the default value. However, on ChangeLog-1.6.2.19: MySQL, placing a NULL in either a float or integer column results ChangeLog-1.6.2.19- in a retrieval of the 0 value. Hence, users get an errant error ChangeLog-1.6.2.19- on load. This patch suppresses that error and makes the value as ChangeLog-1.6.2.19- if it was not there. Note that this cannot be done in the ChangeLog-1.6.2.19- realtime driver, because the lack of difference between NULL and ChangeLog-1.6.2.19- 0 can only be intepreted correctly by the driver itself. If we ChangeLog-1.6.2.19- did it in the realtime driver, then it would be effectively ChangeLog-1.6.2.19- impossible to set any realtime field to 0, because it would act ChangeLog-1.6.2.19- as if the field were unspecified and possibly take on a different ChangeLog-1.6.2.19: value. (closes issue #16683) Reported by: wdoekes ........ ChangeLog-1.6.2.19- ChangeLog-1.6.2.19-2009-12-28 22:13 +0000 [r236716] Jason Parker ChangeLog-1.6.2.19- ChangeLog-1.6.2.19- * main/ast_expr2.c, /, main/ast_expr2.y: Merged revisions 236713 ChangeLog-1.6.2.19- via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ChangeLog-1.6.2.19- ........ r236713 | qwell | 2009-12-28 16:09:40 -0600 (Mon, 28 Dec ChangeLog-1.6.2.19- 2009) | 8 lines Allow "REMAINDER" to function properly in ChangeLog-1.6.2.19: expressions. (closes issue #16427) Reported by: wdoekes Patches: ChangeLog-1.6.2.19: ast16-reminder-remainder.patch uploaded by wdoekes (license 717) ChangeLog-1.6.2.19: Tested by: wdoekes ........ ChangeLog-1.6.2.19- ChangeLog-1.8.5-rc1-2011-05-06 21:06 +0000 [r317861-317917] Russell Bryant ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * channels/chan_sip.c: chan_sip: Destroy variables on a sip_pvt ChangeLog-1.8.5-rc1- before copying vars from the sip_peer. Don't duplicate variables ChangeLog-1.8.5-rc1- on the sip_pvt. Just reset the variable list each time. (closes ChangeLog-1.8.5-rc1: issue #19202) Reported by: wdoekes Patches: ChangeLog-1.8.5-rc1- issue19202_destroy_challenged_invite_chanvars.patch uploaded by ChangeLog-1.8.5-rc1: wdoekes (license 717) ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * channels/chan_sip.c: URI encode less characters in the RPID and ChangeLog-1.8.5-rc1- Contact headers. If this change causes any problems, we will need ChangeLog-1.8.5-rc1- to backport the more extensive uri encoding and decoding handling ChangeLog-1.8.5-rc1- changes that are in trunk/1.10. (closes issue #18686) Reported ChangeLog-1.8.5-rc1: by: wolfgang Patches: quick-and-dirty.patch uploaded by wdoekes ChangeLog-1.8.5-rc1: (license 717) Tested by: wdoekes, devellow, wolfgang, mav3rick ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1-2011-05-03 22:13 +0000 [r316336] Russell Bryant ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * pbx/pbx_dundi.c, channels/chan_mgcp.c, channels/chan_skinny.c: ChangeLog-1.8.5-rc1- Use htons() instead of ntohs() in some places. (closes issue ChangeLog-1.8.5-rc1: #19200) Reported by: wdoekes Patches: issue19200-trunk.patch ChangeLog-1.8.5-rc1: uploaded by wdoekes (license 717) issue19200-1.8.x.patch uploaded ChangeLog-1.8.5-rc1: by wdoekes (license 717) ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1-2010-10-14 18:45 +0000 [r291791] Jeff Peeler ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * main/stdtime/localtime.c: Add missing ifdefs for test framework ChangeLog-1.8.5-rc1- and new locale code. (closes issue #18137) Reported by: ovi ChangeLog-1.8.5-rc1: Patches: 18137_test_framework_ifdef.patch uploaded by wdoekes ChangeLog-1.8.5-rc1: (license 717) 18137_localelist_warning.patch uploaded by wdoekes ChangeLog-1.8.5-rc1- (license 717) Tested by: ovi ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1-2010-06-30 17:28 +0000 [r273233] Paul Belanger ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * res/res_rtp_asterisk.c: Fix rt(c)p set debug ip taking wrong ChangeLog-1.8.5-rc1- argument Also clean up some coding errors. (closes issue #17469) ChangeLog-1.8.5-rc1: Reported by: wdoekes Patches: astsvn-rtp-set-debug-ip.patch ChangeLog-1.8.5-rc1: uploaded by wdoekes (license 717) Tested by: wdoekes, pabelanger ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1-2010-06-03 18:53 +0000 [r267624] Leif Madsen ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * UPGRADE.txt, CHANGES: Update UPGRADE.txt and CHANGE for CDR ChangeLog-1.8.5-rc1- functionality changes. Updated the UPGRADE.txt and CHANGES file ChangeLog-1.8.5-rc1- stating that CDR records will not be explicity written unless ChangeLog-1.8.5-rc1- cdr.conf exists and is configured. (closes issue #17373) Reported ChangeLog-1.8.5-rc1: by: wdoekes Tested by: pabelanger ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1-2010-03-17 00:23 +0000 [r252976-253004] Tilghman Lesher ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * tests/test_gosub.c (added), apps/app_stack.c: Mask out previous ChangeLog-1.8.5-rc1- arguments on each nested invocation of Gosub. (closes issue ChangeLog-1.8.5-rc1: #16758) Reported by: wdoekes Patches: ChangeLog-1.8.5-rc1- 20100316__issue16758.diff.txt uploaded by tilghman (license 14) ChangeLog-1.8.5-rc1- Review: https://reviewboard.asterisk.org/r/561/ ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1-2010-02-02 20:32 +0000 [r244071-244393] Tilghman Lesher ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * funcs/func_math.c: Correct some off-by-one errors, especially ChangeLog-1.8.5-rc1- when expressions don't contain expected spaces. Also include the ChangeLog-1.8.5-rc1- tests provided by the reporter, as regression tests. (closes ChangeLog-1.8.5-rc1: issue #16667) Reported by: wdoekes Patches: ChangeLog-1.8.5-rc1: astsvn-func_match-off-by-one.diff uploaded by wdoekes (license ChangeLog-1.8.5-rc1- 717) ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1-2010-01-26 17:40 +0000 [r243200-243242] David Vossel ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * include/asterisk/utils.h, channels/chan_sip.c, tests/test_utils.c ChangeLog-1.8.5-rc1- (added), main/test.c, main/utils.c: RFC compliant uri and ChangeLog-1.8.5-rc1- display-name encode/decode 1. URI Encoding This patch changes ChangeLog-1.8.5-rc1- ast_uri_encode()'s behavior when doreserved is enabled. ChangeLog-1.8.5-rc1- Previously when doreserved was enabled only a small set of ChangeLog-1.8.5-rc1- reserved characters were encoded. This set was comprised ChangeLog-1.8.5-rc1- primarily of the reserved characters defined in RFC3261 section ChangeLog-1.8.5-rc1- 25.1, but contained other characters as well. Rather than only ChangeLog-1.8.5-rc1- escaping the reserved set, doreserved now escapes all characters ChangeLog-1.8.5-rc1- not within the unreserved set as defined by RFC 3261 and RFC ChangeLog-1.8.5-rc1- 2396. Also, the 'doreserved' variable has been renamed to ChangeLog-1.8.5-rc1- 'do_special_char' in attempts to avoid confusion. When doreserve ChangeLog-1.8.5-rc1- is not enabled, the previous logic of only encoding the ChangeLog-1.8.5-rc1- characters <= 0X1F and > 0X7f remains, except for the '%' ChangeLog-1.8.5-rc1- character, which must always be encoded as it signifies a HEX ChangeLog-1.8.5-rc1- escaped character during the decode process. 2. URI Decoding: ChangeLog-1.8.5-rc1- Break up URI before decode. In chan_sip.c ast_uri_decode is ChangeLog-1.8.5-rc1- called on the entire URI instead of it's individual parts after ChangeLog-1.8.5-rc1- it is parsed. This is not good as ast_uri_decode can introduce ChangeLog-1.8.5-rc1- special characters back into the URI which can mess up parsing. ChangeLog-1.8.5-rc1- This patch resolves this by not decoding a URI until parsing is ChangeLog-1.8.5-rc1- completely done. There are many instances where we check to see ChangeLog-1.8.5-rc1- if pedantic checking is enabled before we decode a URI. In these ChangeLog-1.8.5-rc1- cases a new macro, SIP_PEDANTIC_DECODE, is used on the individual ChangeLog-1.8.5-rc1- parsed segments of the URI rather than constantly putting if ChangeLog-1.8.5-rc1- (pedantic) { decode() } checks everywhere in the code. In the ChangeLog-1.8.5-rc1- areas where ast_uri_decode is not dependent upon pedantic ChangeLog-1.8.5-rc1- checking this macro is not used, but decoding is still moved to ChangeLog-1.8.5-rc1- each individual part of the URI. The only behavior that should ChangeLog-1.8.5-rc1- change from this patch is the time at which decoding occurs. ChangeLog-1.8.5-rc1- Since I had to look over every place URI parsing occurs to create ChangeLog-1.8.5-rc1- this patch, I found several places where we use duplicate code ChangeLog-1.8.5-rc1- for parsing. To consolidate the code, those areas have updated to ChangeLog-1.8.5-rc1- use the parse_uri() function where possible. 3. SIP display-name ChangeLog-1.8.5-rc1- decoding according to RFC3261 section 25. To properly decode the ChangeLog-1.8.5-rc1- display-name portion of a FROM header, chan_sip's ChangeLog-1.8.5-rc1- get_calleridname() function required a complete re-write. More ChangeLog-1.8.5-rc1- information about this change can be found in the comments at the ChangeLog-1.8.5-rc1- beginning of this function. 4. Unit Tests. Unit tests for ChangeLog-1.8.5-rc1- ast_uri_encode, ast_uri_decode, and get_calleridname() have been ChangeLog-1.8.5-rc1- written. This involved the addition of the test_utils.c file for ChangeLog-1.8.5-rc1: testing the utils api. (closes issue #16299) Reported by: wdoekes ChangeLog-1.8.5-rc1: Patches: astsvn-16299-get_calleridname.diff uploaded by wdoekes ChangeLog-1.8.5-rc1- (license 717) get_calleridname_rewrite.diff uploaded by dvossel ChangeLog-1.8.5-rc1: (license 671) Tested by: wdoekes, dvossel, Nick_Lewis Review: ChangeLog-1.8.5-rc1- https://reviewboard.asterisk.org/r/469/ ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1-2010-01-06 16:36 +0000 [r238091] David Vossel ChangeLog-1.8.5-rc1- ChangeLog-1.8.5-rc1- * include/asterisk/test.h: fixes test.c compile issue when ChangeLog-1.8.5-rc1- TEST_FRAMEWORK is not enabled The ast_test_status_update() ChangeLog-1.8.5-rc1- function is defined in test.h. When TEST_FRAMEWORK is not enabled ChangeLog-1.8.5-rc1- a macro is defined as a no-op place holder for this function. The ChangeLog-1.8.5-rc1- macro did not contain the correct number of arguments. This ChangeLog-1.8.5-rc1: caused a compile error. Much thanks to wdoekes for reporting the ChangeLog-1.8.5-rc1- issue and supplying the patch! ChangeLog-1.8.5-rc1-